Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurvePath: Return this in closePath(). #26697

Merged
merged 1 commit into from
Sep 5, 2023
Merged

CurvePath: Return this in closePath(). #26697

merged 1 commit into from
Sep 5, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Sep 5, 2023

Fixed #26696.

Description

The PR makes sure CurvePath.closePath() returns this so it's possible to use the method in a chaining fashion.

@Mugen87 Mugen87 added this to the r157 milestone Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
646.1 kB (160.3 kB) 646.1 kB (160.3 kB) +12 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
438.9 kB (106.3 kB) 438.9 kB (106.3 kB) +0 B

@Mugen87 Mugen87 merged commit 06936fc into mrdoob:dev Sep 5, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close Path doesn't return this
1 participant