Reuse NodeBuilder #26729
Merged
Reuse NodeBuilder #26729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Sep 11, 2023
LeviPesin
reviewed
Sep 12, 2023
|
|
||
| if ( material.version !== this._materialVersion ) { | ||
| for ( const property in material ) { |
There was a problem hiding this comment.
This doesn't work for properties available via getters/setters, right?
There was a problem hiding this comment.
Yes, it will access private properties instead.
5 tasks
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26673
Description
material.needsUpdate=trueNodeBuilderbased fromCache Key, currently the cache uses Material/Geometry as reference. For example, this means that two Materials of the same type with only a different color will be compiled twice instead of reuse theNodeBuilder, this sharing already happens for the GPU Program, but as the code is dynamically generated this optimization process should be API oriented for the Nodes.NodeBuilderStateto reduce memory usage when reuseNodeBuilder