Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchedMesh: Make data copying more robust, handle interleaved attributes #27066

Merged
merged 13 commits into from
Oct 27, 2023
Merged

BatchedMesh: Make data copying more robust, handle interleaved attributes #27066

merged 13 commits into from
Oct 27, 2023

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #25059, #22376

Description

  • Use BufferAttributes getters and setters if array type is different or is an interleaved array.

I'm going to be looking at adding the setGeometryAt and addGeometry functions as well as a small demo next but it may take a bit longer.

cc @takahirox

@gkjohnson gkjohnson added this to the r158 milestone Oct 26, 2023
@Mugen87 Mugen87 merged commit 5e43514 into mrdoob:dev Oct 27, 2023
19 checks passed
@gkjohnson gkjohnson deleted the batch-handle-interleaved branch October 30, 2023 01:33
@CodyJasonBennett CodyJasonBennett mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r158
Development

Successfully merging this pull request may close these issues.
2 participants
@gkjohnson @Mugen87