Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchedMesh: Add setGeometryAt, addGeometry functions #27078

Merged
merged 21 commits into from
Oct 31, 2023
Merged

BatchedMesh: Add setGeometryAt, addGeometry functions #27078

merged 21 commits into from
Oct 31, 2023

Commits on Oct 25, 2023

  1. BatchedMesh: Remove unused fields

    @gkjohnson
    gkjohnson committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    44ad26b View commit details
    Browse the repository at this point in the history

  2. BatchedMesh: Add thrown errors in unimplemented functions

    @gkjohnson
    gkjohnson committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    4f54286 View commit details
    Browse the repository at this point in the history

  3. Add PURE and glsl identifiers

    @gkjohnson
    gkjohnson committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    905d9ee View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Add more error handling

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    7609368 View commit details
    Browse the repository at this point in the history

  2. More errors

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8889181 View commit details
    Browse the repository at this point in the history

  3. Fix batched index overrun

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ffeba15 View commit details
    Browse the repository at this point in the history

  4. BatchedMesh: Check for normalized, as well

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6066ff6 View commit details
    Browse the repository at this point in the history

  5. Fix screenshot

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    0169285 View commit details
    Browse the repository at this point in the history

  6. Add "setGeometry" function

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    bd9491b View commit details
    Browse the repository at this point in the history

  7. Fixes

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    b60bc04 View commit details
    Browse the repository at this point in the history

  8. Remove "applyGeometry"

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9a070d9 View commit details
    Browse the repository at this point in the history

  9. Use "addGeometry" in example

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    1b71761 View commit details
    Browse the repository at this point in the history

  10. Swap arguments

    @gkjohnson
    gkjohnson committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    fbb3f48 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Merge remote-tracking branch 'mrdoob/dev' into batch-set-geometry 

    # Conflicts:
#	examples/jsm/objects/BatchedMesh.js
    @gkjohnson
    gkjohnson committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    0d22631 View commit details
    Browse the repository at this point in the history

  2. Update set geometry functions

    @gkjohnson
    gkjohnson committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    cbf6bb1 View commit details
    Browse the repository at this point in the history

  3. Cleanup

    @gkjohnson
    gkjohnson committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    2d96adc View commit details
    Browse the repository at this point in the history

  4. Add error messages

    @gkjohnson
    gkjohnson committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    29ccf95 View commit details
    Browse the repository at this point in the history

  5. linting

    @gkjohnson
    gkjohnson committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    f186100 View commit details
    Browse the repository at this point in the history

  6. Reset the BATCHING value

    @gkjohnson
    gkjohnson committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    48a9c8b View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary value set

    @gkjohnson
    gkjohnson committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    5ec01d8 View commit details
    Browse the repository at this point in the history

  8. Swap the batch define true / false order

    @gkjohnson
    gkjohnson committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    2ff069d View commit details
    Browse the repository at this point in the history