Renderer: Call ID #27101
Merged
Renderer: Call ID #27101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update after init
This was referenced Nov 7, 2023
LeviPesin
reviewed
Jan 11, 2024
| if ( this.isAnimating === true || this.animationLoop === null || this.nodes === null ) return; | ||
|
|
||
| this.isAnimating = true; | ||
| _init() { | ||
|
|
||
| const update = ( time, frame ) => { | ||
|
|
||
| this.requestId = self.requestAnimationFrame( update ); |
There was a problem hiding this comment.
Actually... is this correct that this function is called every frame using rAF even if animationLoop isn't set? /ping @sunag
There was a problem hiding this comment.
It was intentional, nodeFrame.update() cannot be called in render() to work correctly, this fix cases where no animationLoop was added.
There was a problem hiding this comment.
Why it cannot be called there?
There was a problem hiding this comment.
We need to know what frame we are in to trigger NodeUpdateType.FRAME frame events, otherwise we will only have NodeUpdateType.RENDER call events. The frame counter makes sure which frame is in order to avoid duplicate events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
#26673 (comment),
https://discourse.threejs.org/t/has-anyone-noticed-any-unusual-behavior-in-the-uniform-node/56657/2
Description
This PR adds
info.call,info.compute.call,info.render.calland remove the current behavior ofinfo.render.frame.info.render.frameis incremented every time we callrender()but in theory one frame is the lapse of one keyframe for another, in a single frame we can have several RTT, for example. This caused confusion in the cache system and had duplicate calls in theNodeUpdateType.FRAMEsettings causing overloads and in other cases had problems with bindings updates.