Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial: Introduce outputFinalNode #27576

Closed
wants to merge 2 commits into from

Conversation

RenaudRohlinger
Copy link
Collaborator

Introduce an enhancement to the material node system by adding a new node outputFinalNode that operates at the very end of the pipeline, post tone mapping, fog, and color space adjustments.
This addition unlocks the capability to apply custom effects on a per-material basis, providing a level of control and customization not achievable with a uniform post-processing setup.

Currently the only operation possible is mix, if possible it would be better to be able to apply any operator using tslFn, for example:

material.outputFinalNode = tslFn( ( { color } ) => {
    return color.rgb.addAssign(vec3(0.1));
} )

@sunag
Copy link
Collaborator

sunag commented Jan 17, 2024

I think we have already implemented this feature #26419 and here #27239 a update.

@RenaudRohlinger
Copy link
Collaborator Author

Oh! So that was output, even better. I see thanks 👍

@RenaudRohlinger
Copy link
Collaborator Author

@sunag shouldn't the output property return the final output, post toneMapping, fog and colorSpace?

@sunag
Copy link
Collaborator

sunag commented Jan 18, 2024

@sunag shouldn't the output property return the final output, post toneMapping, fog and colorSpace?

It should return, because it is the total result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants