WebGPURenderer: multiple canvas support #27628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LeviPesin
reviewed
Jan 28, 2024
LeviPesin
reviewed
Jan 28, 2024
|
The API feels amazing!! |
aardgoose
changed the title
Mugen87
reviewed
Feb 24, 2024
|
|
||
| } | ||
|
|
||
| getDrawingBufferSize( target ) { | ||
| getActivePixelRatio() { |
There was a problem hiding this comment.
Is it necessary to introduce all the getActive*() methods? Could getPixelRatio() just work like so:
- Report the pixel ratio of the default canvas render target.
- If a custom canvas render target is set, return its values instead.
There was a problem hiding this comment.
I considered that but was worried about altering the behaviour of those methods, happy to do that instead though, or add a method to getActiveCanvasTarget() for use within the Node classes.
aardgoose
force-pushed
the
crt
branch
2 times, most recently
from
666bb55
to
20df00c
Compare
added 2 commits
July 14, 2024 12:05
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a CanvasRenderTarget() to represent a screen canvas, which can be used via renderer.setRenderTarget() for use with WebGPU, thus supporting multiple canvases.
The default screen canvas state in Renderer() is replaced by a CanvasRenderTarget(). - this may be too much code change?