Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Added sync render()/clear() #27840

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Feb 28, 2024

Related issue: #27597 (comment), #26964

Description

On some Nodes including PMREMGenetaror(WebGPU) that is being developed, we will need to do render call synchronized in the same render pass, so as not to confuse the stack and don't have race condition problem. The best alternative I found so far was to alert the user with an error if they calls render() before initialization and directing them to use renderAsync()

THREE.Renderer: .render() called before the backend is initialized. Try using .renderAsync() instead.

@sunag sunag marked this pull request as ready for review February 28, 2024 18:44
@sunag sunag added this to the r162 milestone Feb 28, 2024
@sunag sunag changed the title WebGPURenderer: Added sync render() WebGPURenderer: Added sync render()/clear() Feb 28, 2024
@sunag sunag merged commit ae1475f into mrdoob:dev Feb 29, 2024
11 checks passed
@sunag sunag deleted the dev-renderAsync branch February 29, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant