Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Anisotropy #28106

Merged
merged 7 commits into from
Apr 10, 2024
Merged

WebGPURenderer: Anisotropy #28106

merged 7 commits into from
Apr 10, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Apr 10, 2024 •
edited
Loading

@sunag sunag marked this pull request as ready for review April 10, 2024 13:06
@sunag sunag merged commit d369861 into mrdoob:dev Apr 10, 2024
11 checks passed
@sunag sunag deleted the dev-anisotropy branch April 10, 2024 19:28
@WestLangley
Copy link
Collaborator

@sunag r164dev webgpu_loader_gltf.html (webgpu backend) is rendering slightly different reflections compared to r163. Also when compared to webgl_loader_gltf.html I'm trying to track it down. Do you have any idea?

@sunag
Copy link
Collaborator Author

sunag commented Apr 15, 2024

As soon as you said I was confirm my hypothesis, it is related to specularF90 because of the fresnel reflection, the default value 1.0 is not always being applied I will correct it, thank you for noticing this!

@sunag sunag mentioned this pull request Apr 15, 2024
Merged
This was referenced Apr 21, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunag @WestLangley