Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: New color space name functions #29259

Merged
merged 1 commit into from
Aug 29, 2024
Merged

TSL: New color space name functions #29259

merged 1 commit into from
Aug 29, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 29, 2024

Related issue: #29248 (comment)

Description

Description updated in this PR

@sunag sunag marked this pull request as ready for review August 29, 2024 11:39
@sunag sunag added this to the r168 milestone Aug 29, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
WebGLRenderer 685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B
WebGPURenderer 818.6 kB (221.2 kB) 818.6 kB (221.2 kB) -27 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
WebGLRenderer 462 kB (111.4 kB) 462 kB (111.4 kB) +0 B
WebGPURenderer 564.8 kB (153.4 kB) 564.8 kB (153.4 kB) -20 B

Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🫶

@sunag
Copy link
Collaborator Author

sunag commented Aug 29, 2024

Thank you too :)

@sunag sunag merged commit 86a663d into mrdoob:dev Aug 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants