LightProbeGenerator: adapt for WebGPU compatibility #29335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2024 20:42
Mugen87
reviewed
Sep 5, 2024
WestLangley
reviewed
Sep 5, 2024
Mugen87
reviewed
Sep 6, 2024
|
Do you mind adding an exception for the https://github.com/mrdoob/three.js/blob/dev/test/e2e/puppeteer.js#L43 I'll revisit this after the merge. |
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29295
The cubeRenderTarget method has been made async which requires the original example to be modified to account for this.
The cube faces from WebGPU have the 'X' faces swapped, and all mirrored vertically.
As an aside: the WebGPU copyTexturetoBuffer() command can return all 6 faces of a cube texture in a single call in a single buffer.