Trackball fixes #3474
Closed
Trackball fixes #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUGZID: Summary: This switches the "screen" variable to use the domElement's dimensions & location rather than the window. It also removes the "radius" variable in favor of using each dimension's value (ie width & height)
|
@mrdoob This look reasonable? |
|
This looks great to me! Good example of how good PR should look like :) |
|
Actually... You should use and target the |
|
Doh! |
|
Almost there! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I've somewhat re-factored how I handled both the screen->element coordinates and the spherical (vs oblong) trackball issues.
Instead of changing getMouseProjectionOnBall, I changed the "screen" variable and the updater in handleResize. This has the side effect that it also affects the pan & zoom elements, but they seem to work fine.
Finally, I've also put in the "noRoll" option which toggles the external roll "ring"