Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Run Recorder in a process instead of thread. #24

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Run Recorder in a process instead of thread. #24

merged 1 commit into from
Nov 16, 2019

Conversation

cmangla
Copy link
Collaborator

@cmangla cmangla commented Nov 16, 2019

Also serialise stop events. Both changes improve reliability.

Description

In Recorder.join(), Thread.join(...) hangs. It is safe to run Recorder in a different process instead of a thread, and that solves this issue.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Also serialise stop events. Both changes improve reliability.
@mre
Copy link
Owner

mre commented Nov 16, 2019

Tested and works. Thanks @cmangla. 😊
Along the way I noticed that the dependencies of the project are quite out-of-date. Will create a PR for that. Maybe you have time to be a reviewer?

@mre mre merged commit 97552cb into mre:master Nov 16, 2019
@cmangla
Copy link
Collaborator Author

cmangla commented Nov 16, 2019

Tested and works. Thanks @cmangla. 😊
Along the way I noticed that the dependencies of the project are quite out-of-date. Will create a PR for that. Maybe you have time to be a reviewer?

You're welcome @mre! Sure, I can review that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants