using struct value as the final default. fixes #13 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephensearles
commented
Dec 23, 2016
| @@ -289,11 +286,12 @@ func coerce(v interface{}, opt interface{}, arg string) (interface{}, error) { | |||
| return nil, fmt.Errorf("invalid value type %T", v) | |||
| } | |||
|
|
|||
| func hasArg(s string) bool { | |||
| for _, arg := range os.Args[1:] { | |||
There was a problem hiding this comment.
I don't think this was ever actually working in most tests. I think they passed because they were using flagSet defaults instead.
There was a problem hiding this comment.
I don't think Visit existed in earlier version of go 🤷♂️
stephensearles
commented
Dec 23, 2016
| v = getter.Get() | ||
| } | ||
| // value | ||
| v = val.Field(i).Interface() |
There was a problem hiding this comment.
this is the primary change
mreiferson
requested changes
Dec 23, 2016
| @@ -289,11 +286,12 @@ func coerce(v interface{}, opt interface{}, arg string) (interface{}, error) { | |||
| return nil, fmt.Errorf("invalid value type %T", v) | |||
| } | |||
|
|
|||
| func hasArg(s string) bool { | |||
| for _, arg := range os.Args[1:] { | |||
There was a problem hiding this comment.
I don't think Visit existed in earlier version of go 🤷♂️
| // flag value | ||
| if getter, ok := flagInst.Value.(flag.Getter); ok { | ||
| v = getter.Get() | ||
| } |
There was a problem hiding this comment.
I think this case is still required e.g. https://github.com/nsqio/nsq/blob/master/apps/nsqd/nsqd.go#L41
Perhaps this should be:
if getter, ok := flagInst.Value.(flag.Getter); ok {
v = getter.Get()
} else {
v = val.Field(i).Interface()
}
This was referenced Dec 23, 2016
|
Thanks for taking care of that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #13 and nsqio/nsq#826