Greatly improved price tracking consistency, fixed edge cases, and other QoL #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…con by altering the number formatting
…ck it is closed causing profit to change
…eward withdraw interfaces
…dle things like deposit boxes, imp-in-a-box, and others
-Fix- Minute by minute GE price changes of held and worn items will no longer interfere with profit -Improvement- Included bank as a resource to monitor profit (emptying pouches, banking reward chests) -Improvement- Added additional monitoring to ensure deposit box profit is accounted for -Fix- Huntsmans kit interaction no longer interferes with profit -Fix- Seed vault no longer interferes with profit -Fix- Fixed opening bank interfaces and doing nothing causing the next change to be ignored -Improvement- Added automatic start setting to begin tracking on first game tick -Fix- Fixed readme pointing to broken image
…omething like 1,953 gold would show as 1.9K instead of 2.0K
|
Wow thanks for this. I'll review it after work |
…ndition to happen again in reverse -Fix- Fixed seed vault tick perfect close race condition
mrhappyasthma
approved these changes
Nov 30, 2024
src/main/java/com/profittracker/ProfitTrackerInventoryValue.java
Outdated
Show resolved
Hide resolved
|
Looks good overall. One nitpick suggestion but otherwise good |
…tions -Dev Internal- Minor cleanup of various container item handling for potential future improvements -Improvement- Changed essence pouches to storage only items that ignore profit changes -Improvement- Added and fixed a few storage items to ensure profit tracking occurs
-Fix- Fixed new bank tracking holding onto previous bank state between toggling plugin -Dev Internal- Fixed profit calculation debug message issue with concatenation instead of addition -Dev Internal- Updated several instances of dif to difference -Fix- Closed possibility of race condition when calculating profit in case prices can be updated in parallel
|
Are you good for me to merge this? |
Yeah I closed up a few more things that I noticed in testing. My mems ran out so I can't test well anymore, but it was working as intended. Swapping between specialty worlds and normal worlds can mess the numbers up (like leagues), but I don't think it is too important an issue. Even if there might be some other strange edge cases, they shouldn't outweigh the improvements IMO. |
|
PR to update the plugin on pluginhub to this latest version: runelite/plugin-hub#7159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Improvements