Make Crc generic over implementation #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilles
force-pushed
the
generic-impl-poc
branch
from
a503384
to
456dc87
Compare
This allows for new implementations to be added without breaking API compatibility. Signed-off-by: Akhil Velagapudi <4@4khil.com>
akhilles
force-pushed
the
generic-impl-poc
branch
from
456dc87
to
4aa4536
Compare
akhilles
changed the title
|
@KillingSpark please take a look. |
|
Yep that works for me and it seems like a non-breaking change to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for new implementations to be added without breaking API compatibility.