Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when opening diagramless puzzles #138

Closed
jpd236 opened this issue Apr 12, 2021 · 0 comments · Fixed by #139
Closed

Crash when opening diagramless puzzles #138

jpd236 opened this issue Apr 12, 2021 · 0 comments · Fixed by #139

Comments

@jpd236
Copy link
Contributor

jpd236 commented Apr 12, 2021

This looks like a regression from #136:

 	puz.dll!puz::Square::GetCol() Line 181	C++
 	puz.dll!puz::GetDirection(const puz::Square & first, const puz::Square & second) Line 422	C++
 	puz.dll!puz::ListImpl::GetDirection() Line 226	C++
 	puz.dll!puz::Word::GetDirection() Line 327	C++
>	XWord.exe!XGridCtrl::SetPuzzle(puz::Puzzle * puz) Line 299	C++
 	XWord.exe!MyFrame::ShowGrid() Line 829	C++
 	XWord.exe!MyFrame::ShowPuzzle(bool update) Line 807	C++
 	XWord.exe!MyFrame::LoadPuzzle(const wxString & filename, const puz::Puzzle::FileHandlerDesc * handler) Line 654	C++
 	XWord.exe!MyFrame::LoadPuzzle(const wxString & filename) Line 596	C++
 	XWord.exe!MyFrame::OnOpenPuzzle(wxCommandEvent & __formal) Line 1967	C++

Presumably GetDirection is failing because it doesn't work on a diagramless puzzle.
jpd236 added a commit to jpd236/xword that referenced this issue Apr 12, 2021
@jpd236
Skip inference of "first" clue list on Diagramless puzzles.
8a43222 
Avoids a call to GetDirection() which crashes. We'll just assume the
first direction is ACROSS for these puzzles.

Fixes mrichards42#138
@jpd236 jpd236 mentioned this issue Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip inference of "first" clue list on Diagramless puzzles. jpd236/xword
1 participant
@jpd236