Improve handling of different capitalizations of "Across" and "Down". #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting a ClueList, normalize them to the canonical "Across" and "Down" as is used elsewhere in XWord. This fixes features like reuse of existing settings for the Across and Down clue panes and saving the file as an Across Lite .puz file. Note that this results in the displayed clue list using the canonical name and not the provided name, since MyFrame::ShowClues is built around using the keys and not the titles. However, this is only a minor cosmetic difference that seems harder to fix.
|
Works for me! The clue heading doesn't bother me all that much, but I'm sure we could fix it eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a ClueList, normalize them to the canonical "Across" and
"Down" as is used elsewhere in XWord. This fixes features like reuse of
existing settings for the Across and Down clue panes and saving the file
as an Across Lite .puz file.
Note that this results in the displayed clue list using the canonical
name and not the provided name, since MyFrame::ShowClues is built around
using the keys and not the titles. However, this is only a minor
cosmetic difference that seems harder to fix.
See #140