Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering of annotation squares. #151

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

jpd236
Copy link
Contributor

@jpd236 jpd236 commented Jun 6, 2021

Use the same background rendering behavior as for regular white squares
instead of rendering as a black square, and don't render borders. This
matches the Crossword Nexus behavior.

Use the same background rendering behavior as for regular white squares
instead of rendering as a black square, and don't render borders. This
matches the Crossword Nexus behavior.
@jpd236
Copy link
Contributor Author

jpd236 commented Jun 6, 2021

I could be convinced to leave the borders unchanged. IMO, they look nicer this way for Acrostics, and reasonable when in a grid surrounded by other (bordered) squares, but may look funkier in other situations.

@mrichards42
Copy link
Owner

This makes sense to me. It wouldn't be a bad idea to allow annotations to have borders, if we were ever to implement border styles, but I like this as a default. Annotation suggests to me that it's just printing some text in the grid, so you shouldn't expect it to look like a normal square with a border.

@mrichards42 mrichards42 merged commit ea83fee into mrichards42:master Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants