More flexible solution character handling. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Permit "*" as a valid grid character. While Across Lite doesn't
support it, other formats do. It can't be entered directly (since it is
bound as the shortcut for circling/uncircling a letter to match Across
Lite), but it can be entered as a rebus.
- When setting square text or solutions, never set the empty string,
even if ToGrid returns one (due to an invalid character, namely a black
square (".") or the symbol indicator ("[")). This ensures that bounds
checks pass in HasSolutionRebus.
See mrichards42#185
|
I'm a little less sure of this one since text stuff can be pretty fiddly, but logically it makes sense that we'd want to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permit "*" as a valid grid character. While Across Lite doesn't
support it, other formats do. It can't be entered directly (since it is
bound as the shortcut for circling/uncircling a letter to match Across
Lite), but it can be entered as a rebus.
When setting square text or solutions, never set the empty string,
even if ToGrid returns one (due to an invalid character, namely a black
square (".") or the symbol indicator ("[")). This ensures that bounds
checks pass in HasSolutionRebus.
See #185