Enable TSAN builds on CI for Functional Tests.

This enables TSAN checking when running the functional tests in CI. This is currently only enabled on Linux since the various races there were fixed when project-chip#7478 landed. When Darwin races are fixed, tsan can be enabled for those too.
mrjerryjohns · Jun 22, 2021 · cf79d93 · cf79d93
1 parent 2541621
commit cf79d93
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 8 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -28,6 +28,10 @@ jobs:
         name: Test Suites - Linux
         timeout-minutes: 60
 
+        strategy:
+          matrix:
+            type: [no_tsan, with_tsan]
+
         if: github.actor != 'restyled-io[bot]'
         runs-on: ubuntu-latest
 
@@ -61,11 +65,23 @@ jobs:
             - name: Build all clusters app
               timeout-minutes: 5
               run: |
-                  scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone/ chip_config_network_layer_ble=false
+                  case ${{ matrix.type }} in
+                    "no_tsan") GN_ARGS='is_tsan=false';;
+                    "with_tsan") GN_ARGS='is_tsan=true';;
+                    *) ;;
+                  esac
+              
+                  scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone/ chip_config_network_layer_ble=false "$GN_ARGS"
             - name: Build chip-tool
               timeout-minutes: 5
               run: |
-                  scripts/examples/gn_build_example.sh examples/chip-tool out/debug/standalone/
+                  case ${{ matrix.type }} in
+                    "no_tsan") GN_ARGS='is_tsan=false';;
+                    "with_tsan") GN_ARGS='is_tsan=true';;
+                    *) ;;
+                  esac
+                
+                  scripts/examples/gn_build_example.sh examples/chip-tool out/debug/standalone/ "$GN_ARGS"
             - name: Copy objdir
               run: |
                   # The idea is to not upload our objdir unless builds have
@@ -95,7 +111,6 @@ jobs:
     test_suites_darwin:
         name: Test Suites - Darwin
         timeout-minutes: 60
-
         if: github.actor != 'restyled-io[bot]'
         runs-on: macos-latest
 

diff --git a/third_party/cirque/repo b/third_party/cirque/repo
diff --git a/third_party/openthread/repo b/third_party/openthread/repo
diff --git a/third_party/pigweed/repo b/third_party/pigweed/repo
diff --git a/third_party/qpg_sdk/repo b/third_party/qpg_sdk/repo
diff --git a/third_party/zap/repo b/third_party/zap/repo
+2 −8		.github/workflows/main.yml
+0 −5		ARCHITECTURE.md
+5 −9		WORKSPACE
+0 −13		cirque/capabilities/BUILD
+0 −71		cirque/capabilities/test/test_trafficcontrol_capability.py
+0 −59		cirque/capabilities/trafficcontrolcapability.py
+9 −8		cirque/grpc/BUILD
+1 −2		cirque/grpc/client.py
+0 −22		cirque/grpc/service.py
+0 −8		cirque/home/home.py
+4 −2		cirque/nodes/dockernode.py
+1 −1		cirque/proto/BUILD
+0 −5		cirque/proto/capability.proto
+0 −4		cirque/proto/device.proto
+1 −2		cirque/resources/Dockerfile.generic_node
+7 −5		cirque/restservice/BUILD
+1 −1		examples/test_flask_virtual_home.py
+0 −1		requirements.txt
+11 −13		run_tests.sh
+11 −12		utils/pystyletest/pystyletest.bzl
+1 −5		examples/platforms/simulation/radio.c
+1 −1		include/openthread/instance.h
+6 −11		include/openthread/platform/radio.h
+0 −1		include/openthread/platform/settings.h
+2 −22		include/openthread/srp_client.h
+0 −11		src/cli/README_SRP_CLIENT.md
+7 −17		src/cli/cli_srp_client.cpp
+0 −7		src/core/api/srp_client_api.cpp
+0 −57		src/core/common/settings.cpp
+0 −89		src/core/common/settings.hpp
+1 −17		src/core/config/srp_client.h
+1 −2		src/core/mac/mac.cpp
+2 −7		src/core/mac/sub_mac.cpp
+0 −1		src/core/meshcop/meshcop_tlvs.cpp
+0 −61		src/core/net/srp_client.cpp
+3 −18		src/core/net/srp_client.hpp
+6 −8		src/core/radio/radio.hpp
+1 −2		src/core/thread/mle.cpp
+4 −14		src/lib/spinel/spinel.h
+1 −17		src/ncp/ncp_base_mtd.cpp
+1 −1		src/posix/platform/backbone.cpp
+65 −80		src/posix/platform/daemon.cpp
+0 −61		src/posix/platform/daemon.hpp
+1 −1		src/posix/platform/infra_if.cpp
+1 −1		src/posix/platform/multicast_routing.cpp
+30 −0		src/posix/platform/platform-posix.h
+9 −3		src/posix/platform/system.cpp
+0 −2		tests/scripts/thread-cert/Makefile.am
+0 −162		tests/scripts/thread-cert/test_srp_client_save_server_info.py
+1 −5		tests/unit/test_platform.cpp