Symbol tables #72
Merged
Symbol tables #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qvalentin
force-pushed
the
feature/symbol-tables
branch
from
eca9b20 to
271cac9
Compare
This was referenced Apr 25, 2024
Closed
qvalentin
force-pushed
the
feature/symbol-tables
branch
2 times, most recently
from
4cd95a5 to
c679d9f
Compare
qvalentin
force-pushed
the
feature/symbol-tables
branch
from
6630f69 to
88706f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring of hover, completion and definition.
By parsing the template ast into a symbol table that contains info about which nodes have semantic meaning.
The symbol table currently contains info about:
With the symbol table many usecases became much easier to implement, since a lot of the required parsing is already done. This also allowed adding the references usecase pretty easy.
The refactoring of the usecases allows for adding new features very easy without having a lot of, if-else like before.