Batch of fixes #262
Batch of fixes #262
Conversation
Fix the icon's position of the default dashboards
Add icon on button and improve message display
Mainly on the Additionals plugin's dashboards, but also on "My page". Fixes mrliptontea#222
|
Awesome. Thanks! |
|
Nice! @mrliptontea would you have time to look into this? |
There was a problem hiding this comment.
I am not able to check these changes myself, broadly they look OK. However, issues I see:
- Some of these changes touch basic Redmine layout - were these changes tested in:
- Different configurations? E.g. fixed layout
true/false. - Earlier Redmine versions? Although I guess it shouldn't matter as much, they're old.
- Different configurations? E.g. fixed layout
- Few places need to use variables instead of hard-coded values (e.g. icons) for improved readability and consistency.
I also need to make linting GitHub action work.
src/sass/components/_plugins.scss
Outdated
| transform: translateY(-175%); | ||
| @if $sidebar-position == "right" { | ||
| right: 15px; | ||
| } | ||
| } | ||
|
|
||
| .flyout-menu .dashboard-system-default { | ||
| position: absolute; | ||
| right: 10px; | ||
| transform: translateY(-190%); |
There was a problem hiding this comment.
This (and -175% above) are a bit specific/odd values. Do they work correctly on different window sizes? If yes - can you add a comment and explain why these values?
There was a problem hiding this comment.
Yes this works on different windows sizes, but it doesn't when changing some variables.
The icon added by the plugin is outside the a tag used to draw the tab. So I solved this by computing existing variables. It should be more explicit.
Yes I tried to test these changes in different configurations : fixed layout + css-grid-layout/$flexbox-layout + sidebar-position. Regarding earlier Redmine versions, I only tested on the 2 latest releases. |
In hope this PR will help you keep this awesome theme working with newer versions of Redmine 🤞 🚀
Fixes issues #222, #233, #242, #245, #246, #253, and few others not already reported 🐛 🩹
Tested on Redmine 4.2.10 and 5.0.5 with the following plugins enabed :