refactor(utils): Prevent double negative symbol when converting patterns

mrmlnc · May 1, 2018 · 22a0850 · 22a0850
1 parent 69a905d
commit 22a0850
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/utils/pattern.spec.ts b/src/utils/pattern.spec.ts
@@ -69,6 +69,14 @@ describe('Utils → Pattern', () => {
 
 			assert.equal(actual, expected);
 		});
+
+		it('should returns pattern without changes', () => {
+			const expected: Pattern = '!*.js';
+
+			const actual = util.convertToNegativePattern('!*.js');
+
+			assert.equal(actual, expected);
+		});
 	});
 
 	describe('.isNegativePattern', () => {

diff --git a/src/utils/pattern.ts b/src/utils/pattern.ts
@@ -30,17 +30,17 @@ export function unixifyPattern(pattern: Pattern): Pattern {
 }
 
 /**
- * Returns negative pattern as positive pattern.
+ * Returns negative pattern as positive pattern if required.
  */
 export function convertToPositivePattern(pattern: Pattern): Pattern {
 	return isNegativePattern(pattern) ? pattern.slice(1) : pattern;
 }
 
 /**
- * Returns positive pattern as negative pattern.
+ * Returns positive pattern as negative pattern if required.
  */
 export function convertToNegativePattern(pattern: Pattern): Pattern {
-	return '!' + pattern;
+	return isNegativePattern(pattern) ? pattern : '!' + pattern;
 }
 
 /**