Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
In most cases, users do not use this option. There are only a couple of places on GitHub right now where users specify concurrency. The value passed there is
os.cpu().length
.When specifying any value, the concurrency is always limited by the libuv library.
Currently, the
concurrency
option is not functioning correctly. For each task, a reader with its own queue is created. This means that if you specify theconcurrency:1
option and define three tasks, three calls will actually be sent to libuv thread pool instead of one.fast-glob/src/index.ts
Lines 27 to 34 in 4b71e29
Currently, it would be easier for me to simply remove this option rather than create a shared queue for all tasks.
If anyone needs this opportunity, please let me know.
What changes did you make? (Give an overview)
…