Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply list of base colors #5

Merged
merged 2 commits into from
Feb 22, 2016
Merged

Simply list of base colors #5

merged 2 commits into from
Feb 22, 2016

Conversation

AlexanderKozhevin
Copy link
Contributor

I think this is a good thing. I needed to use such a list in my project.

@mrmlnc
Copy link
Owner

mrmlnc commented Feb 21, 2016

Thanks for PR. 🐼 But could you give some explanation? Why need this list in the library?

@AlexanderKozhevin
Copy link
Contributor Author

It's like a basic color palette. And for some cases it's easy to have full list of it. Especially if you want to make pure material style.
As for me, I did a custom styles for chart library and I needed to use this basic colors variables, basic ones. And it's definitely not comfortable to scroll though the long file.

@mrmlnc
Copy link
Owner

mrmlnc commented Feb 22, 2016

Hmm, sounds pretty good. Fix the comments and I'll take this PR.

@AlexanderKozhevin
Copy link
Contributor Author

Are you talking about the title?

//
// List of base colors
//

Change to this?

//
// List of base colors

@mrmlnc
Copy link
Owner

mrmlnc commented Feb 22, 2016

Lines 13 - 15 in Less version and Stylus version.
image

@AlexanderKozhevin
Copy link
Contributor Author

Fixed it)

mrmlnc added a commit that referenced this pull request Feb 22, 2016
@mrmlnc mrmlnc merged commit 62e3090 into mrmlnc:master Feb 22, 2016
@mrmlnc
Copy link
Owner

mrmlnc commented Feb 22, 2016

Thanks for work 💪

You can use version 2.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants