fix: Delete HybridObject copy & move ctors (#402)

mrousavy · Dec 6, 2024 · 5147fc7 · 5147fc7
1 parent 4956fed
commit 5147fc7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/packages/react-native-nitro-modules/android/src/main/cpp/turbomodule/JNitroModules.cpp b/packages/react-native-nitro-modules/android/src/main/cpp/turbomodule/JNitroModules.cpp
@@ -10,8 +10,6 @@
 
 namespace margelo::nitro {
 
-JNitroModules::JNitroModules() = default;
-
 jni::local_ref<JNitroModules::jhybriddata> JNitroModules::initHybrid(jni::alias_ref<JNitroModules::jhybridobject>) {
   return makeCxxInstance();
 }

diff --git a/packages/react-native-nitro-modules/android/src/main/cpp/turbomodule/JNitroModules.hpp b/packages/react-native-nitro-modules/android/src/main/cpp/turbomodule/JNitroModules.hpp
@@ -18,7 +18,7 @@ class JNitroModules final : public jni::HybridClass<JNitroModules> {
   static auto constexpr kJavaDescriptor = "Lcom/margelo/nitro/NitroModules;";
 
 private:
-  explicit JNitroModules();
+  explicit JNitroModules() = default;
 
 private:
   // JNI Methods

diff --git a/packages/react-native-nitro-modules/cpp/core/HybridObject.hpp b/packages/react-native-nitro-modules/cpp/core/HybridObject.hpp
@@ -38,11 +38,11 @@ class HybridObject : public virtual jsi::NativeState, public HybridObjectPrototy
   /**
    * HybridObjects cannot be copied.
    */
-  HybridObject(const HybridObject& copy) = default;
+  HybridObject(const HybridObject& copy) = delete;
   /**
    * HybridObjects cannot be moved.
    */
-  HybridObject(HybridObject&& move) = default;
+  HybridObject(HybridObject&& move) = delete;
   /**
    * HybridObjects cannot be default-constructed!
    */