fix: Fix moving sharedFunction after first callback call

mrousavy · Nov 20, 2024 · d0052ec · d0052ec
1 parent 12276b8
commit d0052ec
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/packages/react-native-nitro-modules/cpp/jsi/JSIConverter+Function.hpp b/packages/react-native-nitro-modules/cpp/jsi/JSIConverter+Function.hpp
@@ -56,14 +56,12 @@ struct JSIConverter<std::function<ReturnType(Args...)>> final {
       }
 
       if constexpr (std::is_void_v<ResultingType>) {
-        dispatcher->runAsync([&runtime, sharedFunction = std::move(sharedFunction), ... args = std::move(args)]() {
-          callJSFunction(runtime, sharedFunction, args...);
-        });
+        dispatcher->runAsync(
+            [&runtime, sharedFunction, ... args = std::move(args)]() { callJSFunction(runtime, sharedFunction, args...); });
       } else {
-        return dispatcher->runAsyncAwaitable<ResultingType>(
-            [&runtime, sharedFunction = std::move(sharedFunction), ... args = std::move(args)]() -> ResultingType {
-              return callJSFunction(runtime, sharedFunction, args...);
-            });
+        return dispatcher->runAsyncAwaitable<ResultingType>([&runtime, sharedFunction, ... args = std::move(args)]() -> ResultingType {
+          return callJSFunction(runtime, sharedFunction, args...);
+        });
       }
     };
   }