perf: Make OwningReference/BorrowingReference lock-free, and only allocate memory block once
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
mrousavy
changed the title
OwningReference/BorrowingReference only allocate memory block onceOwningReference/BorrowingReference only allocate memory block once and remove locking
mrousavy
changed the title
OwningReference/BorrowingReference only allocate memory block once and remove lockingOwningReference/BorrowingReference lock-free, and only allocate memory block once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up allocations of new
OwningReference/BorrowingReferencetypes - which Nitro uses extensively in the codebase.new bool+new size_t+new size_t+new mutex, we now only allocate a single state block:new ReferenceState- which is a struct. 📈std::recursive_mutexwe now usestd::mutex- which is faster and lighter 🪶OwningReferenceandBorrowingReference! 🥳 OnlyOwningLockanddestroy()need to lock the mutex :)