Fix types of createBlurhashFromImage #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Mr. Duplessis - thanks for your PR my G! CI fails unfortunately, looks like it still generated an abstract class that takes Doubles?
|
|
Maybe something changed in codegen, example is on 0.73 and my all where I tested new arch is 0.74. Are u ok to only support 0.74 for new arch? |
|
yup that's fine! we upgrade the example then |
|
Good! I can update the example in a follow up |
|
Is it okay if I wait with the release until the example works? |
|
Sure! |
janicduplessis
added a commit
to janicduplessis/react-native-blurhash
that referenced
this pull request
Jul 30, 2024
This reverts commit 06d5a40.
mrousavy
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are supposed to be Ints and not Doubles, this fixes compilation with new arch enabled since codegen generates the types with Int.