-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Error on React Native 0.71.0 #497
Comments
Pull request with the necessary changes seems to be ready already but not yet merged: #480 (0.71 has just been released a couple of hours ago). |
you can use an early version from git yarn add mrousavy/react-native-mmkv#feat/migrate-rn-71
|
👎🏼for Fabric yes, but our need is using RN 0.71.X without Fabric |
Why you can't use the Fabric? |
because am using other libs that do not support fabric yet |
I would also echo the need to continue support for the old architecture. There are a number of react native libraries that can't be updated to the new architecture whilst it does not support static frameworks, e.g. react-native-firebase |
@mrousavy please do you confirm that the upcoming release will work without enabling Fabric ? |
@hamdij0maa according to this note in the pull request it will only work on 0.71 with fabric enabled:
Meaning if you cannot enable fabric you'll have to stay on 0.70.6. Fabric is now the default architecture for RN, so this breaking change makes sense. |
It's not the default :v Fabric renderer is not enabled by default, and most of libs example @Flashlist by shopify does not support fabric renderer yet :v |
@mrousavy
|
@hamdij0maa You got a point, didn't know it wasn't already enabled by default. |
No prob brother, |
I think y'all missread If you are on new arch, you'll need 0.71, otherwise you should still be fine. It's just saying that new arch won't work on 0.68, 0.69 and 0.70. |
Yes, just confirming 😂 |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
These tags are insanely annoying, stop spamming or I ban you from using RN MMKV. I am running a company and I am currently busy with a few company related things, I will continue to work on an open-source project I made for free (and none of you guys here are paying me for that) when I have some free time. I expect this to happen later today. |
Just published 2.6.0, this should work on RN 0.71 with new and old architecture! 🚀 Thanks for your help @Titozzz ❤️ |
thank you for the update,
|
Working fine for me, thanks! |
Thank you very much for the update. But I am getting an error. Something is conflicting with the react-native-svg library I understand. :/
|
same error |
same with Type com.facebook.react.viewmanagers.RNGestureHandlerButtonManagerDelegate is defined multiple times: /node_modules/react-native-gesture-handler/android/build/.transforms/9016f10b3bbc73680278818232d909ac/transformed/debug/com/facebook/react/viewmanagers/RNGestureHandlerButtonManagerDelegate.dex, /node_modules/react-native-mmkv/android/build/.transforms/05fe2efb67e79eed93a93868192077d9/transformed/debug/com/facebook/react/viewmanagers/RNGestureHandlerButtonManagerDelegate.dex |
Did you nuke your gradle cache? https://stackoverflow.com/a/30450020/5281431 |
That looks like a react-native-gesture-handler error... |
Even though I did a |
Same here, |
I'm also getting an error
|
I get the same error as @mikalaiulasevich:
Edit: Don't think its a problem with react native gesture handler. For some reason, when this library builds, it has a lot of viewmanagers compiled that aren't from this library. |
@mrousavy looks like the issue was with the
I can open a PR if that's correct. Edit: PR: #499. Feel free to close if not relevant. |
Very interesting. Although newArchEnabled=false in android/gradle.properties it was always going into this if. 🤔 apply plugin: 'com.facebook.react' I completely deleted this and it works, amazing. Thanks @inssein 🥳 |
Works like a charm! 💟 |
Thanks for your PR @inssein - it's weird that I didn't have this error while testing - which other libraries also do the same approach? |
Thanks for dealing with that so quickly @mrousavy. As for your question, I looked at https://github.com/software-mansion/react-native-gesture-handler/blob/main/android/build.gradle#L60 and https://github.com/software-mansion/react-native-svg/blob/main/android/build.gradle#L27 |
FAILURE: Build failed with an exception.
[CXX1101] NDK at C:\Users\Your\AppData\Local\Android\Sdk\ndk\23.1.7779620 did not have a source.properties file build failed as ndk already installedRN-0.71.1 @inssein what are the changes need to do... |
FAILURE: Build failed with an exception.
|
**/node_modules/react-native-mmkv/android/build.gradle' line: 173
A problem occurred evaluating project ':react-native-mmkv'.
**/node_modules/react-native/android' to contain exactly one file, however, it contains no files.
The text was updated successfully, but these errors were encountered: