-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate to React Native 0.71 #480
Conversation
mrousavy
commented
Nov 10, 2022
•
edited
Loading
edited
- Uses React Native core as prefabs on Android (binary compatibility)
- Uses new buildscript (build.gradle and CMakeLists are now significantly smaller, no more downloading, unzipping, header importing or cpp compiling - we now use prefabs for JSI)
- Supports running on the new architecture (Fabric, TurboModules)
example/package.json
Outdated
"@tsconfig/react-native": "^2.0.2", | ||
"@types/jest": "^29.2.2", | ||
"@types/react": "^18.0.25", | ||
"@types/react-native": "^0.70.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NickGerleman you mean all 4 packages, or just the @types/react-native package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think he means just the react-native ones; in 0.71 we bundle them into the node_module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Just @types/react-native which should also now be builtin with newer types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removed 'em - I think it works! :)
any ETA on this ? It's really appreciated |
This already works, but I am waiting for RN 0.71 to be released before I merge & ship this :) |
Oh, nice! happy to hear it's ready |
Is there any plan to support Paper for those who still haven't migrated to the new architecture? |
React native 0.71 + new arch failed:
|
I got this error when building android using this mmkv version (react-native 0.71) - new arch enabled: As reference:
|