fix: android build for react native 0.69 #1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantorm
force-pushed
the
fix-android-build
branch
from
3b926d7 to
f62cedb
Compare
LucasClaude
approved these changes
Jul 9, 2022
|
when could this be merged and released? |
4 tasks
|
This PR fixes #1118, but then you get another error (issue #1125) (For anyone looking for a quickfix: you can disable frame processors, beware you lose some functionalities like bar code scanner) |
kantorm
force-pushed
the
fix-android-build
branch
from
f62cedb to
3f82421
Compare
This was referenced Aug 1, 2022
|
Looking forward to this one. @blu3beri do the last changes bring it up to snuff? |
To the best of my knowledge, yes! |
|
Are we able to get this merged, @LucasClaude? |
This was referenced Aug 8, 2022
|
i need this,Are we able to get this merged? |
tomekzaw
approved these changes
Aug 9, 2022
|
These Android build issues were fixed in the PR linked just above, for others interested. |
|
@spsaucier I'm closing this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes build issues on Android for React Native 0.69
Changes
Tested on
Pixel 3, Android 12, react-native 0.69 with hermes on