[V2] Correct Frame Processor loading between Objc/Swift #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iBotPeaches
changed the title
|
Okay, this works in the Example and resolves my issues on v2 with the frame processors now. vision-camera.mp4 |
mrousavy
requested changes
Oct 17, 2023
example/ios/Frame Processor Plugins/Example Plugin (Objective-C)/ExampleFrameProcessorPlugin.m
Outdated
Show resolved
Hide resolved
example/ios/Frame Processor Plugins/Example Plugin (Swift)/ExamplePluginSwift.swift
Outdated
Show resolved
Hide resolved
| @@ -33,7 +33,7 @@ | |||
| */ | |||
| #define VISION_EXPORT_FRAME_PROCESSOR(frame_processor) \ | |||
| \ | |||
| +(void)initialize \ | |||
| +(void)load \ | |||
| @@ -53,13 +53,11 @@ objc_name : NSObject<FrameProcessorPluginBase> | |||
| @end \ | |||
| @implementation objc_name (FrameProcessorPlugin) \ | |||
| \ | |||
| +(void)initialize \ | |||
| __attribute__((constructor)) static void VISION_CONCAT(initialize_, objc_name)() \ | |||
There was a problem hiding this comment.
Ahh, yea I forgot about that lol. I dont know why I reverted that
This reverts commit ba01d28.
|
Thanks for this changes, you saved me! Unfortunately I can't use version 3 yet because I have to readjust some internal things in my code due to the change from ImageProxy to Frame, in custom frame processor. I just added them locally, I will wait for them to merge in v2 to update my project. |
|
Let's go! |
|
Thanks. Will await the new tag and update our plugin/project. |
Just released an update on npm with this fix 💪 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes Frame Processors (Swift/Objc). I used the following for research:
Doing initialize appeared to be too early (or not consistent) as we might load code before reanimated is ready. When we move to "load" - that is no longer allowed on Swift due to the interop between objc. attribute constructor runs after load and seems the best place.
Changes
Tested on
Related issues