feat: Always download CodeScanner
model instead of relying on Google Play Services
#2355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Instead of using RegEx replaces, this change adds a new prop to the
build.gradle
setup of VisionCamera:VisionCamera_enableCodeScanner
.VisionCamera_enableCodeScanner
can be configured in your app'sgradle.properties
file:react-native-vision-camera/package/example/android/gradle.properties
Lines 44 to 45 in fdbc2db
VisionCamera_enableCodeScanner
is set tofalse
(the default), the Google Play Services MLKit library will be used which only includes the code for Barcode detection but not the 2.4 MB model. On phones that support Google Play Services, the model can be dynamically downloaded once you use a CodeScanner (useCodeScanner
).VisionCamera_enableCodeScanner
is set totrue
, VisionCamera will include the full MLKit dependency instead of the dynamic google play services one, and will bundle the 2.4 MB model into your app. This will work on every Android phone then, even without Google Play Services.react-native-vision-camera/package/android/build.gradle
Lines 168 to 175 in fdbc2db
Changes
Tested on
Related issues