feat: Create persistent CaptureSession to avoid any blackscreen issues or errors

[mrousavy]

What

Rewrites the CameraSession to use a PersistentCameraCaptureSession instead of a CameraDevice and CameraCaptureSession combination to avoid the need of dynamically creating and dropping CameraCaptureSession instances as it is currently.

Before:

private var device: CameraDevice? = null
private var session: CameraCaptureSession? = null
// ^ both could get destroyed by Android, go `null`, go out of sync, etc...

After:

private var session: PersistentCameraCaptureSession
// ^ is always there, I can just set what I need and it internally figures it out

In VisionCamera's CameraSession, we have the following dependency graph:

graph TD;

isActive[isActive: Boolean]-->run;
id[cameraId: String]-->device(cameraDevice: CameraDevice);
options[cameraConfig: CameraConfig]-->request[captureRequest: CaptureRequest];
id-->request;
device-->session(cameraSession: CameraCaptureSession);
outputs["outputs: List<SurfaceOutput>"]-->session;

request-->run["start() / stop()"];
session-->run;

Loading

Important to note is that CameraDevice and CameraCaptureSession are asynchronous resources, meaning two things:

1. Creating them takes time and is async (suspend) (which is fine)
2. They can be closed or disconnected by the OS at any point, in which we need to also update their dependant values and tear down the camera session with a chance of rebuilding it again later.

See #2495 for more details

Changes

• Creates PersistentCameraCaptureSession which can auto-recover devices in a persistent class. This makes the code much simpler and safer
• Uses PersistentCameraCaptureSession instead of CameraDevice/CameraCaptureSession
• Uses abortCaptures() when tearing down the session so that completion callbacks are called
• Skips configuration if preview is null

Tested on

Related issues

• Fixes 🐛 Camera Preview becomes black screen if use it in carousel(iOS/Android) #2432
• Fixes 🐛 Black screen on Redmi K30 Pro #2405
• Fixes 🐛 TOO_MANY_OPEN_CAMERAS error when rendering multiple Cameras #2378
• Fixes 🐛 OnePlus 8T on 3.7.0 configure_streams() Invalid argument(s) for configure_streams() #2376 (because I now avoid starting the session without a preview)
• Fixes 🐛 takePhoto stuck on step 2/3 #2372 (because I now use abortCaptures())
• Fixes 🐛 App crash using QR scanner (useCodeScanner) #2341
• Fixes 🐛 In the demo, using the navigation.navigate('CodeScannerPage') to enter the page will not scan the content #2321
• Fixes 🐛 Crash on Android using code scanner #2442
• Fixes 🐛 Black screen on Redmi Note 11 #2363

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-vision-camera	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2024 1:19pm

[mrousavy]

holy shit I think it works