Fix photo not saving in Android example app on Android 13+ #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android 13+, requesting the WRITE_EXTERNAL_STORAGE permission immediately denies, without asking the user. The @react-native-camera-roll/camera-roll plugin being used already supports using scoped storage for saving images on Android 13+, so this commit skips the permission check in that case, since no permissions are needed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Awesome, nice catch thank you! |
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
On Android 13+, requesting the WRITE_EXTERNAL_STORAGE permission immediately denies, without asking the user. The @react-native-camera-roll/camera-roll plugin being used already supports using scoped storage for saving images on Android 13+, so this commit skips the permission check in that case, since no permissions are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes an issue in the example app which prevented the saving of photos on Android 13+. I came across this when testing #2519 and needed to save some example photos.
On Android 13+, requesting the
WRITE_EXTERNAL_STORAGEpermission immediately denies, without asking the user. Instead we need to use scoped storage. The@react-native-camera-roll/camera-rollplugin being used already supports using scoped storage for saving images on Android 13+, so all we need to do is skip the permission check in that case.Changes
Tested on
Related issues