perf: Fix double configuration on device change #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a situation that happened on every device change (or initial mount) where the device was configured after the session, separately, instead of just all at once causing an additonal delay/flicker of the prevjew.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
mrousavy
changed the title
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
…y#2537) * fix: Fix double configuration on device change Fixes a situation that happened on every device change (or initial mount) where the device was configured after the session, separately, instead of just all at once causing an additonal delay/flicker of the prevjew. * Try? * Format * Update CameraSession.swift * Use `defer` * Throw `.device`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the visual Camera zoom glitch that happened everytime you switch the Camera device, as well as on the initial mount of the camera.
The reason for this bug was that the device was configured after the session, meaning we had a double configuration instead of one single batch, causing an additonal delay/flicker of the preview.
This now also means the session starts faster! 🔥 🚀
Before:
RPReplay_Final1707826712.MP4
After:
RPReplay_Final1707826776.MP4
Changes
Tested on
Related issues