Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix 60 FPS crashing on some Samsungs #2556

Merged
merged 4 commits into from
Feb 14, 2024
Merged

fix: Fix 60 FPS crashing on some Samsungs #2556

merged 4 commits into from
Feb 14, 2024

Conversation

mrousavy
Copy link
Owner

What

Fixes 60 FPS Cameras crashing on some Samsungs by clamping them to 30 FPS when the CamcorderProfile cannot record at 60 FPS:

Camera could do 60 FPS at 2400x1080, but Media Encoder can only do 30 FPS. Clamping to 30 FPS...
Camera could do 60 FPS at 1920x1440, but Media Encoder can only do 30 FPS. Clamping to 30 FPS...
Camera could do 60 FPS at 1920x1080, but Media Encoder can only do 30 FPS. Clamping to 30 FPS...
Camera could do 60 FPS at 1920x864, but Media Encoder can only do 30 FPS. Clamping to 30 FPS...
Camera could do 60 FPS at 1440x1080, but Media Encoder can only do 30 FPS. Clamping to 30 FPS...
Camera could do 60 FPS at 1088x1088, but Media Encoder can only do 30 FPS. Clamping to 30 FPS...
Camera could do 60 FPS at 1280x720, but Media Encoder can only do 30 FPS. Clamping to 30 FPS...
Camera could do 60 FPS at 960x720, but Media Encoder can only do 30 FPS. Clamping to 30 FPS...

Changes

Tested on

Related issues

@vercel Vercel
Copy link

vercel bot commented Feb 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 11:26am

@mrousavy mrousavy merged commit 4786885 into main Feb 14, 2024
5 checks passed
@mrousavy mrousavy deleted the fix/fix-60fps-crash branch February 14, 2024 11:47
isaaccolson pushed a commit to isaaccolson/deliveries-mobile that referenced this pull request Oct 30, 2024
@mrousavy
fix: Fix 60 FPS crashing on some Samsungs (mrousavy#2556)
2f0eab1 
* fix: Fix 60 FPS crash on Samsung by checking `CamcorderProfile.maxFps`

* Log FPS clamp

* Update CameraDeviceDetails.kt

* Format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrousavy