Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix format Preview and Video Capture resolution setting #325

Merged
merged 2 commits into from
Aug 5, 2021
Merged

fix: Fix format Preview and Video Capture resolution setting #325

merged 2 commits into from
Aug 5, 2021

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Aug 5, 2021

What

Changes

Tested on

Related issues

@mrousavy mrousavy added 🐛 bug Something isn't working 🤖 android Issue affects the Android platform labels Aug 5, 2021
@mrousavy mrousavy mentioned this pull request Aug 5, 2021
Closed
4 tasks
@mrousavy mrousavy merged commit 37db643 into main Aug 5, 2021
@mrousavy mrousavy deleted the fix/android-format-resolution branch August 5, 2021 13:54
@xulihang xulihang mentioned this pull request Feb 17, 2022
Closed
isaaccolson pushed a commit to isaaccolson/deliveries-mobile that referenced this pull request Oct 30, 2024
@mrousavy
fix: Fix format Preview and Video Capture resolution setting (mrous…
715bd22 
…avy#325)

* fix: Actually use a format's `videoSize` for Preview/Video Capture

* `setDefaultResolution` -> `setTargetResolution`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤖 android Issue affects the Android platform 🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Preset prop has no effect on Android
1 participant
@mrousavy