Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource_keycloak_ldap_role_mapper.go #560

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

DOboznyi
Copy link
Contributor

Seems as this field was accidentally removed

@DOboznyi
Copy link
Contributor Author

@mrparkers could you check this change?

@mrparkers
Copy link
Owner

Hey @DOboznyi, maybe I'm missing something here, but it looks like this field was removed from Keycloak. I tested Keycloak 11, 12, and 13, and none of them have this setting anymore. That's why I removed it.

Are you using a version of Keycloak that still uses this field? If so, I can accept this PR and cut a release for you, but I would also want to see the docs updated to specify this as a supported field again.

@DOboznyi
Copy link
Contributor Author

Hey. They have such setting and as i can see from keycloak code it's still present (Link)

Copy link
Owner

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, my mistake then. Thanks for the PR! I'll get the docs fixed as well.

@mrparkers mrparkers merged commit 253a07e into mrparkers:master Jul 19, 2021
@DOboznyi
Copy link
Contributor Author

When will be new release with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants