Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add support for multiple makefiles #70

Merged

Conversation

trinitronx
Copy link
Contributor

@trinitronx trinitronx commented Apr 28, 2022

Description

As a follow-up to #69, this PR adds support for passing multiple Makefile / *.mk paths
as command-line arguments, just like how pre-commit run --all-files will execute checkmake when a repo contains multiple *.mk files.

Checklist

Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.

  • CI passes
  • Description of proposed change
    • See above
  • Documentation (README, docs/, man pages) is updated
    • See README.md, man/man1/checkmake.1.md file diffs
  • Existing issue is referenced if there is one
  • Unit tests for the proposed change
    • See *_test.go file diffs

@trinitronx trinitronx mentioned this pull request Apr 28, 2022
5 tasks
trinitronx added a commit to LyraPhase/uncommon-build that referenced this pull request Apr 28, 2022
trinitronx added a commit to trinitronx/gospikes that referenced this pull request Apr 28, 2022
@mrtazz
Copy link
Owner

mrtazz commented Nov 15, 2022

thanks for taking the time to contribute!

@mrtazz mrtazz merged commit 7e99987 into mrtazz:main Nov 15, 2022
@trinitronx trinitronx deleted the feature/add-support-for-multiple-makefiles branch July 14, 2024 19:27
trinitronx added a commit to LyraPhase/uncommon-build that referenced this pull request Jul 17, 2024
Merged PRs: mrtazz/checkmake#69, and mrtazz/checkmake#70

These were released in `checkmake` version 0.2.2
trinitronx added a commit to LyraPhase/uncommon-build that referenced this pull request Jul 17, 2024
Merged PRs: mrtazz/checkmake#69, and mrtazz/checkmake#70

These were released in `checkmake` version 0.2.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants