Skip to content

Commit

Permalink
ci: ensure tests use newly installed chromedriver and not chromedrive…
Browse files Browse the repository at this point in the history
…r from `node_modules` (dequelabs#794)
  • Loading branch information
Zidious committed Aug 22, 2023
1 parent d40ec13 commit 377d5eb
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ jobs:
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
- run: npm run build --prefix=packages/puppeteer
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chrome chromedriver --verbose
run: npx browser-driver-manager install chromedriver --verbose
working-directory: packages/puppeteer
- run: npm run build --prefix=packages/puppeteer
- run: npm run coverage --prefix=packages/puppeteer
- run: npm run test:esm --prefix=packages/puppeteer

Expand All @@ -50,9 +51,10 @@ jobs:
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chrome chromedriver --verbose
run: npx browser-driver-manager install chromedriver --verbose
working-directory: packages/cli
# Re-build packages, ensuring packages/webdriverjs/dist exists.
- run: npx lerna run prepare
# lerna link after installing the latest version of chromedriver, as we depend on webdriverJS
Expand All @@ -76,7 +78,8 @@ jobs:
- run: npm run bootstrap -- --ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chrome chromedriver --verbose
run: npx browser-driver-manager install chromedriver --verbose
working-directory: packages/webdriverjs
- run: npm run build --prefix=packages/webdriverjs
- run: npm run coverage --prefix=packages/webdriverjs
- run: npm run test:esm --prefix=packages/webdriverjs
Expand All @@ -97,7 +100,8 @@ jobs:
- run: npm run bootstrap -- --ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chrome chromedriver --verbose
run: npx browser-driver-manager install chromedriver --verbose
working-directory: packages/webdriverio
- run: npm run build --prefix=packages/webdriverio
- run: npm run coverage --prefix=packages/webdriverio
- run: npm run test:esm --prefix=packages/webdriverio
Expand Down

0 comments on commit 377d5eb

Please sign in to comment.