Update base.py for issue #182, #186 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2021 11:43
Changed the way `sum` was computed in `getImagesTotal()` to avoid black screen with "no (new) images could be found" in the warning log.
Fix Fill and Do Nothing image handling.
|
Let me know tomorrow if these changes worked as expected and we'll merge then |
|
After a day, this is still running without a hitch. |
Addresses mrworf#186
dadr
changed the title
|
I've added a commit to this PR - it now addresses #186 as well. |
mrworf
reviewed
Jun 27, 2021
| @@ -694,7 +696,7 @@ def requestUrl(self, url, destination=None, params=None, data=None, usePost=Fals | |||
| break | |||
| except: | |||
| logging.exception('Issues downloading') | |||
| time.sleep(tries / 10) # Back off 10, 20, ... depending on tries | |||
| time.sleep(tries * 10) # Back off 10, 20, ... depending on tries | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the way
sumwas computed ingetImagesTotal()to avoid black screen with "no (new) images could be found" in the warning log.