Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook & Message Stream bugs #36

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Conversation

tgrosinger
Copy link

I found these bugs in my previous implementations as I started using these endpoints.

When listing all webhooks it should not provide the MessageStream query
parameter at all. When the parameter is empty Postmark returns an error.
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023

Codecov Report

Merging #36 (79a1820) into master (5ed9b01) will decrease coverage by 0.49%.
The diff coverage is 40.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   96.61%   96.13%   -0.49%     
==========================================
  Files          13       13              
  Lines         591      595       +4     
==========================================
+ Hits          571      572       +1     
- Misses         14       16       +2     
- Partials        6        7       +1     
Flag Coverage Δ
unittests 96.13% <40.00%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
message_streams.go 96.61% <ø> (ø)
webhooks.go 94.23% <40.00%> (-5.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed9b01...79a1820. Read the comment docs.

@mrz1836 mrz1836 added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Aug 13, 2023
@mrz1836 mrz1836 self-requested a review August 13, 2023 11:25
Copy link
Owner

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 1b069f0 into mrz1836:master Aug 13, 2023
@tgrosinger tgrosinger deleted the webhook-bugs branch August 13, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants