Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppresions API fix #49

Merged
merged 2 commits into from
Feb 28, 2024
Merged

suppresions API fix #49

merged 2 commits into from
Feb 28, 2024

Conversation

morus12
Copy link

@morus12 morus12 commented Feb 28, 2024

This PR corrects the formatting issues with delete and create suppression requests. I tested it against the Postmark API, and it appears to be functioning properly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.10%. Comparing base (193f487) to head (c158926).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   97.10%   97.10%           
=======================================
  Files          13       13           
  Lines         552      552           
=======================================
  Hits          536      536           
  Misses          9        9           
  Partials        7        7           
Flag Coverage Δ
unittests 97.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
suppressions.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 193f487...c158926. Read the comment docs.

@mrz1836 mrz1836 added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Feb 28, 2024
@mrz1836 mrz1836 self-requested a review February 28, 2024 14:51
Copy link
Owner

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit d5f506a into mrz1836:master Feb 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants