Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue periodically:
when trying to send an email through this library.
Based on research (golang/go#62453, https://github.com/stripe/stripe-go/pull/711/files, https://ragoragino.dev/blog/softwareengineering/2022-02-05-goaway-test/index.html) it looks like Golang attempts a retry when receiving
GOAWAY
from a server. [https://sourcegraph.com/github.com/golang/net/-/commit/cffdcf672aee934982473246bc7e9a8ba446aa9b?visible=2](Go code here)But, this means that we need to define a
GetBody
function in the request to allow the http2 package to retry. Since the payload we have here is static, we can set it equal to theBody
.I tested this by patching my dependency with this new version, and my emails still send, so I think this at least won't break anything.