Skip to content

0.6.1 - Code review changes

Compare
Choose a tag to compare
@ms3056 ms3056 released this 08 Jul 02:26
· 2 commits to main since this release

.theme-dark {
Same feedback as with your other plugin, these variables are too generic, and you should use the build in variables from Obsidian if possible.

Your CSS class names are also a bit too generic.

updated with same compromise - variables changed to be specific and Style Settings control of colors added.

dateFormatSetting.settingEl.style.borderTop = "none";
You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

completed - all styling of the settings moved to CSS

new Notice("Maximum timezone entries added.");
Why is there a limit here?

limit imposed based on tester feedback and the fact the more than 5 makes the UI look awkward. If the user community believes we should expand the number beyond 5 I will consider the change.