-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RTL text #396
Comments
Can you include a screenshot? If the device system language is set to RTL, that should work. |
Can you post the links to the feeds you are having this issue with? I can test it out and roll out a fix. |
I think this might take a lot more effort than I originally though. The easy option is what we have now, which would rely on the device language. Unfortunately anymore than that, requires identifying language at runtime and then updating the web page essentially. Will have to revisit that approach later on. |
See RTL support Implementation in Read you Maybe it will help you |
Can you share an image that contains the right language direction for the above content so that I can verify the changes when I get to this? |
I think I addressed the issue. The app will no longer depend on just the system language, it will depend on the content language as well. In terms of mixed languages, it's rendering correctly as far as I can tell. When I check the links on my system in a browser, it displays in the same way. So, not much I can do in that aspect. Here are few screenshots for the preview |
Thank you for your response, I tried the latest version of github action and the result is good for both rtl and ltr, but there is a problem in displaying Code snippets, it shows rtl instead of ltr |
My mother tongue is Persian so the feeds i have are Persian
The problem is that Twine only support text alignment for left to right languages
So the arabic typescript will show up distorted when they contain English words in their sentences
The text was updated successfully, but these errors were encountered: