Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RTL text #396

Closed
iJahangard opened this issue Mar 21, 2024 · 10 comments
Closed

Support RTL text #396

iJahangard opened this issue Mar 21, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@iJahangard
Copy link

My mother tongue is Persian so the feeds i have are Persian
The problem is that Twine only support text alignment for left to right languages
So the arabic typescript will show up distorted when they contain English words in their sentences

@iJahangard iJahangard added the bug Something isn't working label Mar 21, 2024
@msasikanth
Copy link
Owner

Can you include a screenshot? If the device system language is set to RTL, that should work.

@othmahammedi
Copy link

Screenshot_2024-05-25-19-31-37-336_dev.sasikanth.rss.reader.jpg

Article titles appear rtl when the system language is Arabic, but the content of the articles is ltr.

while the headings and content are ltr when the system language is

@othmahammedi
Copy link

The problem is still the same, for example, if I'm following articles in Arabic and English, the text alignment depends on the system language and therefore the text alignment is wrong in one article or even in the same article if it contains rtl and ltr languages.

Screenshot_2024-08-01-20-08-27-544_dev.sasikanth.rss.reader.jpg

Screenshot_2024-08-01-20-08-39-599_dev.sasikanth.rss.reader.jpg

@msasikanth
Copy link
Owner

Can you post the links to the feeds you are having this issue with? I can test it out and roll out a fix.

@othmahammedi
Copy link

@msasikanth
Copy link
Owner

I think this might take a lot more effort than I originally though. The easy option is what we have now, which would rely on the device language. Unfortunately anymore than that, requires identifying language at runtime and then updating the web page essentially. Will have to revisit that approach later on.

@othmahammedi
Copy link

See RTL support Implementation in Read you Maybe it will help you

Ashinch/ReadYou#378

@msasikanth
Copy link
Owner

Can you share an image that contains the right language direction for the above content so that I can verify the changes when I get to this?

@msasikanth msasikanth reopened this Aug 7, 2024
@msasikanth msasikanth changed the title Support RTL text Support RTL text in reader view Aug 7, 2024
@msasikanth msasikanth changed the title Support RTL text in reader view Support RTL text Aug 7, 2024
@msasikanth
Copy link
Owner

I think I addressed the issue. The app will no longer depend on just the system language, it will depend on the content language as well.

In terms of mixed languages, it's rendering correctly as far as I can tell. When I check the links on my system in a browser, it displays in the same way. So, not much I can do in that aspect.

Here are few screenshots for the preview

Screenshot_20240807_202844
Screenshot_20240807_202847
Screenshot_20240807_202850

msasikanth added a commit that referenced this issue Aug 7, 2024
@othmahammedi
Copy link

Thank you for your response, I tried the latest version of github action and the result is good for both rtl and ltr, but there is a problem in displaying Code snippets, it shows rtl instead of ltr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants