Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get correct icon for feed when available #785

Open
luigihenrick opened this issue Jan 28, 2025 · 2 comments
Open

Get correct icon for feed when available #785

luigihenrick opened this issue Jan 28, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@luigihenrick
Copy link

luigihenrick commented Jan 28, 2025

Is your feature request related to a problem? Please describe.

Yes, when adding a new feed, it does not get the correct icon specified on FreshRSS.

Describe the solution you'd like

While configuring FreshRSS is possible to share your feeds and specify the correct icon for it.
On other RSS readers, specifically using GoFeed, the reader does two requests, one passing format = RSS f=rss and other with HTML param f=html in order to get the icon, would it be possible to implement a similar solution for twine?
As I use FreshRSS for all my feeds, currently there's no way to differentiate the feeds.
Thanks in advance, amazing app!

Additional context

Requests monitored using GoFeed

Image

Twine screenshot

Image

@msasikanth msasikanth added the bug Something isn't working label Jan 29, 2025
@msasikanth
Copy link
Owner

Oh, haven't tried it with the FreshRss feeds before. However, we are looking into adding support for fresh RSS service this year. In the meantime, I will look into this. Thanks for flagging this.

@luigihenrick
Copy link
Author

My first analysis on this was wrong, the correct way to get the icon is reading the correct properties on RSS xml.
PR created: #786. @msasikanth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants